Skip to content

fix(go/plugins/googlegenai): use one FunctionDeclaration for all tools #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 14, 2025
Merged

fix(go/plugins/googlegenai): use one FunctionDeclaration for all tools #3686

merged 6 commits into from
Oct 14, 2025

Conversation

hugoaguirre
Copy link
Contributor

@hugoaguirre hugoaguirre commented Oct 8, 2025 •
edited
Loading

Checklist (if applicable):

@github-actions github-actions bot added the go label Oct 8, 2025
@hugoaguirre hugoaguirre marked this pull request as ready for review October 10, 2025 15:09
@hugoaguirre hugoaguirre requested a review from apascal07 October 10, 2025 15:09
krishnaKapadia
krishnaKapadia approved these changes Oct 12, 2025
View reviewed changes
Copy link

@krishnaKapadia krishnaKapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯

apascal07
apascal07 reviewed Oct 14, 2025
View reviewed changes
@hugoaguirre hugoaguirre changed the title fix(go/plugins/googlegenai): use one FunctionDeclaration for all tools fix(go/plugins/googlegenai): use one FunctionDeclaration for all tools Oct 14, 2025
@apascal07 apascal07 enabled auto-merge (squash) October 14, 2025 18:40
@apascal07 apascal07 merged commit 5a9bf7b into main Oct 14, 2025
6 checks passed
@apascal07 apascal07 deleted the haguirre/tools branch October 14, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apascal07 apascal07 apascal07 approved these changes

+2 more reviewers

@krishnaKapadia krishnaKapadia krishnaKapadia approved these changes

@pano-skylakis pano-skylakis pano-skylakis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

go

Projects

Genkit Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugoaguirre @apascal07 @krishnaKapadia @pano-skylakis